Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code: Clarify and improve handling of multiple proposals for same height/round #833

Open
6 tasks
romac opened this issue Feb 5, 2025 · 0 comments
Open
6 tasks
Labels
application Related to building applications on top of Malachite code Code/implementation related core Related to the core consensus implementation
Milestone

Comments

@romac
Copy link
Member

romac commented Feb 5, 2025

Summary

There's currently ambiguity around how multiple proposals for the same height/round should be handled, particularly in cases of Byzantine proposers. The current implementation has the application discard subsequent proposals after the first one, but this needs to be documented and potentially revised.

Action items

  • Document current behavior regarding proposal handling in tutorials and doc comments
  • Document the need for ValueSync in scenarios with a Byzantine proposer
  • Consider implementing support for multiple proposals per height/round:
    • Review existing partial implementation
    • Design test cases for Byzantine scenarios
    • Implement changes to allow consensus to store multiple proposal values
@romac romac added application Related to building applications on top of Malachite code Code/implementation related core Related to the core consensus implementation labels Feb 5, 2025
@romac romac added this to the Phase 5 milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application Related to building applications on top of Malachite code Code/implementation related core Related to the core consensus implementation
Projects
None yet
Development

No branches or pull requests

1 participant