Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibc-derive does not work if only depend on ibc-core #999

Closed
Farhad-Shabani opened this issue Dec 1, 2023 · 3 comments · Fixed by #1037
Closed

ibc-derive does not work if only depend on ibc-core #999

Farhad-Shabani opened this issue Dec 1, 2023 · 3 comments · Fixed by #1037
Labels
O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Milestone
0.50.0

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Dec 1, 2023 •
edited
Loading

Description

The current implementation of ibc-derive exclusively supports projects dependent on the ibc meta-crate, where the required types for implementing ClientState and ConsensusState traits are imported directly from ibc.
This poses a limitation as not all projects necessarily rely on ibc. To enhance the utility of ibc-derive, it should support projects that may depend on the ibc-core (or even ibc-core-client) crates.
@Farhad-Shabani Farhad-Shabani added the O: usability Objective: aims to enhance user experience (UX) and streamline product usability label Dec 1, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Dec 1, 2023
@seanchen1991
Copy link
Contributor

Does addressing this issue just involve updating the import paths for all of the functions in the Imports module?

@Farhad-Shabani
Copy link
Member Author

Does addressing this issue just involve updating the import paths for all of the functions in the Imports module?

It's a bit trickier. The macro needs to manage three distinct group of paths, depending on which of the ibc, ibc-core, or ibc-core-client crates a user selects.

@mina86
Copy link
Contributor

mina86 commented Dec 21, 2023

Related: #1017

@Farhad-Shabani Farhad-Shabani mentioned this issue Jan 10, 2024
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani added this to the 0.50.0 milestone Jan 12, 2024
@Farhad-Shabani Farhad-Shabani changed the title ibc-derive does not work if only depend on ibc-core or ibc-core-client ibc-derive does not work if only depend on ibc-core Jan 12, 2024
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
None yet
Milestone
0.50.0
3 participants
@mina86 @seanchen1991 @Farhad-Shabani