Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICS04] Expose channel message types as public #952

Closed
Farhad-Shabani opened this issue Nov 8, 2023 · 0 comments · Fixed by #954
Closed

[ICS04] Expose channel message types as public #952

Farhad-Shabani opened this issue Nov 8, 2023 · 0 comments · Fixed by #954
Assignees
Labels
O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Overview

Currently, our domain message types in the ics04_channel module are defined as private - pub(crate) - restricting external libraries from accessing and utilizing them. (At the moment, only these domain message types are not publicly accessible).
This came to my attention when splitting our mock implementation into a separate crate. In order to craft IBC messages for various testing scenarios, the mock implementation requires access to these domain types.

Proposal

Making the ics04_channel domain message types public to enable other libraries to access and use them as necessary.

@Farhad-Shabani Farhad-Shabani added the O: usability Objective: aims to enhance user experience (UX) and streamline product usability label Nov 8, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Nov 8, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Nov 8, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Nov 10, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.48.0 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant