Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo test fails with no-default-features #770

Closed
rnbguy opened this issue Jul 17, 2023 · 1 comment · Fixed by #989
Closed

cargo test fails with no-default-features #770

rnbguy opened this issue Jul 17, 2023 · 1 comment · Fixed by #989
Labels
A: good-first-issue Admin: good for newcomers O: testing Objective: aims to improve testing coverage

Comments

@rnbguy
Copy link
Member

rnbguy commented Jul 17, 2023

Bug Summary

Cargo test without default features fails to compile.

cargo test --package ibc --no-default-features

Details

The root cause is the ibc package is compiled with default serde flag. Yet, there are places (shown in the compile errors), where some of the serde enabled crates and functionalities are imported or used without serde flag.

Version

c20e491

@rnbguy
Copy link
Member Author

rnbguy commented Jul 17, 2023

As suggested by @Farhad-Shabani, the simple solution is to add cargo test --package ibc --no-default-features in CI.

Also, it'd be nice, if we can cargo test for possible feature combinations. cargo-hack offers an easy CLI for doing this.

@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs Jul 18, 2023
@Farhad-Shabani Farhad-Shabani added the O: testing Objective: aims to improve testing coverage label Jul 18, 2023
@Farhad-Shabani Farhad-Shabani added the A: good-first-issue Admin: good for newcomers label Sep 27, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: good-first-issue Admin: good for newcomers O: testing Objective: aims to improve testing coverage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants