Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No timeout_packet send to controller chain after estimated gas is higher than max from host chain #3695

Closed
5 tasks
mmsqe opened this issue Nov 13, 2023 · 3 comments

Comments

@mmsqe
Copy link
Contributor

mmsqe commented Nov 13, 2023

Summary of Bug

Hermes will not send timeout packet when estimated gas exceeds max gas, so the channel state can't get closed after timeout, while go relayer works as expected.

Version

current master

Steps to Reproduce

  1. register ica account
  2. fund ica account
  3. submit large txs to trigger the exceeds max gas error in relayer
  4. wait for channel state get closed after timeout

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Nov 13, 2023
@romac romac changed the title no timeout_packet send to controller chain after estimated gas is higher than max from host chain No timeout_packet send to controller chain after estimated gas is higher than max from host chain Jan 3, 2024
@devashishdxt
Copy link

@romac Is someone working on this? If not, can you provide an approximate outline of changes required so that I can start working on this? This is a blocker for us.

@romac
Copy link
Member

romac commented Jul 22, 2024

@ljoss17 Can you please take a look?

@mmsqe
Copy link
Contributor Author

mmsqe commented Jul 23, 2024

Sorry for the late reply, channel closed correctly after MsgChannelCloseConfirm, seems we need to set smaller timeout to trigger MsgTimeout first.

@mmsqe mmsqe closed this as completed Jul 23, 2024
@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Hermes Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants