Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tx size might set max_tx_size to a value greater than 90% of the genesis block param max_size #2595

Closed
5 tasks
AlianBenabdallah opened this issue Aug 26, 2022 · 0 comments · Fixed by #2645
Labels
A: bug Admin: something isn't working
Milestone

Comments

@AlianBenabdallah
Copy link
Contributor

Summary of Bug

I created a config file for the hub with the config auto command. The health-check outputs :

2022-08-26T15:54:21.321683Z  INFO ThreadId(01) using default configuration from '$HOME/.hermes/config.toml'
2022-08-26T15:54:21.321882Z  INFO ThreadId(01) [cosmoshub-4] performing health check...
2022-08-26T15:54:22.909256Z  WARN ThreadId(15) Hermes might be misconfigured for chain 'cosmoshub-4'
2022-08-26T15:54:22.909289Z  WARN ThreadId(15)     Reason: semantic config validation failed for option `max_tx_size` for chain 'cosmoshub-4', reason: `max_tx_size` = 2097152 is greater than 90% of the consensus parameter `max_size` = 200000
2022-08-26T15:54:22.909295Z  WARN ThreadId(15)     Some Hermes features may not work in this mode!
2022-08-26T15:54:22.909339Z  WARN ThreadId(01) [cosmoshub-4] chain is unhealthy
2022-08-26T15:54:22.909374Z  INFO ThreadId(01) [osmosis-1] performing health check...
2022-08-26T15:54:23.954362Z  INFO ThreadId(01) chain is healthy chain=osmosis-1
SUCCESS performed health check for all chains in the config

The auto config uses the default MaxTxSize defined here.

Version

hermes 1.0.0+a4133751

Steps to Reproduce

hermes config auto --output ~/.hermes/config.toml
hermes health-check

Acceptance Criteria

health-check does not output any error for a config using the default value.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@AlianBenabdallah AlianBenabdallah added the A: bug Admin: something isn't working label Aug 26, 2022
@adizere adizere added this to the v1.1 milestone Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants