From 3a2b3a1ad42f83d7ee9e29df19b270979554fbd9 Mon Sep 17 00:00:00 2001 From: Josh Powers Date: Mon, 18 Dec 2023 06:52:32 -0700 Subject: [PATCH 1/2] fix(outputs.prometheus_client): Default empty scheme to TCP fixes: #14468 --- plugins/outputs/prometheus_client/prometheus_client.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/outputs/prometheus_client/prometheus_client.go b/plugins/outputs/prometheus_client/prometheus_client.go index af3bdc30848bd..3cf6f52287bac 100644 --- a/plugins/outputs/prometheus_client/prometheus_client.go +++ b/plugins/outputs/prometheus_client/prometheus_client.go @@ -217,7 +217,7 @@ func (p *PrometheusClient) listen() (net.Listener, error) { return p.listenTCP(p.Listen) } switch strings.ToLower(u.Scheme) { - case "tcp", "http": + case "", "tcp", "http": return p.listenTCP(u.Host) case "vsock": return p.listenVsock(u.Host) From 7cb0156dfb5ebc81f2d4d237e558b129a88ef939 Mon Sep 17 00:00:00 2001 From: Josh Powers Date: Tue, 2 Jan 2024 09:06:01 -0700 Subject: [PATCH 2/2] default to tcp always --- plugins/outputs/prometheus_client/prometheus_client.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/outputs/prometheus_client/prometheus_client.go b/plugins/outputs/prometheus_client/prometheus_client.go index 3cf6f52287bac..a43b45fa1ff15 100644 --- a/plugins/outputs/prometheus_client/prometheus_client.go +++ b/plugins/outputs/prometheus_client/prometheus_client.go @@ -5,7 +5,6 @@ import ( "context" "crypto/tls" _ "embed" - "errors" "fmt" "net" "net/http" @@ -221,8 +220,9 @@ func (p *PrometheusClient) listen() (net.Listener, error) { return p.listenTCP(u.Host) case "vsock": return p.listenVsock(u.Host) + default: + return p.listenTCP(u.Host) } - return nil, errors.New("Unknown scheme") } func (p *PrometheusClient) Connect() error {