Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starlark Processor: Access to previous metrics, store variables #7793

Closed
victornet opened this issue Jul 7, 2020 · 3 comments
Closed

Starlark Processor: Access to previous metrics, store variables #7793

victornet opened this issue Jul 7, 2020 · 3 comments
Labels
area/starlark feature request Requests for new plugin and for new features to existing plugins

Comments

@victornet
Copy link
Contributor

Feature Request

Hi,

this is regarding the new starlark processor plugin, #7194

I would like to calculate the difference between two metrics (previous and current), see #6870

In the readme is mentioned, that the global context is frozen, fileio etc is not possible.

So, is there a possibility to store variables not using the global context? Or read previous values?

Proposal:

Store last value in variable to get difference of metric, detect overflows in values, calculate e.g. response time for disk io, based on timing and number of operations.

Current behavior:

Not possible, global context is frozen.

Desired behavior:

Read/write variables in global context or store previous metric.

Use case:

Gather disk response times for read and write operations.

@danielnelson
Copy link
Contributor

It is not possible right now, but we might allow it in the future after we gain a bit more experience with Starlark. You will be able to use the execd processor, also new in 1.15, to do this.

@danielnelson danielnelson added the feature request Requests for new plugin and for new features to existing plugins label Jul 7, 2020
@essobedo
Copy link
Contributor

The corresponding PR #8447

@ssoroka
Copy link
Contributor

ssoroka commented Nov 30, 2020

merged in #8447

@ssoroka ssoroka closed this as completed Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/starlark feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

5 participants