Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxDB 1.7.9 authentication setting for /debug/vars access #6588

Closed
timhallinflux opened this issue Oct 28, 2019 · 2 comments · Fixed by #6668
Closed

InfluxDB 1.7.9 authentication setting for /debug/vars access #6588

timhallinflux opened this issue Oct 28, 2019 · 2 comments · Fixed by #6668
Assignees
Milestone

Comments

@timhallinflux
Copy link
Contributor

Feature Request

Need new, optional settings for InfluxDB v1 plugin to allow for authenticated access to /debug/vars.
username/password must be supplied if the the InfluxDB config pprof-auth-enabled = true is set.

Proposal:

Please add this support to the InfluxDB v1 plugin.

@russorat russorat added this to the 1.13.0 milestone Oct 28, 2019
@russorat russorat added the ready label Oct 28, 2019
@russorat russorat removed their assignment Oct 28, 2019
@glinton glinton self-assigned this Oct 30, 2019
@glinton glinton changed the title InfluxDB 1.7.9 now has HTTPS setting for /debug/vars access InfluxDB 1.7.9 authentication setting for /debug/vars access Oct 30, 2019
@glinton
Copy link
Contributor

glinton commented Oct 30, 2019

Reproducing/testing notes: In order for pprof-auth-enabled to be enabled, auth-enabled and pprof-enabled must also be set to true.

  auth-enabled = true
  pprof-enabled = true
  pprof-auth-enabled = true

The requested functionality is already supported by including the username/password into the url in the config (must use this method as a separately defined username and password may not apply to every url defined in the list.

urls = ["http://user:pass@localhost:8086/debug/vars"]

I'm leaving this open so we can sanitize the logs.

@danielnelson
Copy link
Contributor

I assume that this endpoint supports HTTP Basic Auth. If so we should add a username and password option for this and not use or recommend the userinfo section of the URL, as its use was deprecated long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants