-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of Redis COMMANDSTATS fields added in 6.2 #13861
Comments
Thanks for the issue and very specifically laying out what needs to get added. I have put up #13866 which adds the new fields and a test to ensure it is collected correctly. If you could grab the artifacts from the PR I would appreciate you confirming the new metrics are collected successfully as well. Thanks |
Thanks for implementing this so quickly. 🙇 When I tested the following in my local environment, I could see that the metrics were being collected well.
and It would be nice to see the changes added to the README related to produce as well. |
Can you provide the above output as line protocol (e.g. run telegraf with --test or use the outputs.file) and I could add an example in there? |
Of course, I attached the telegraf test output. the host and server tags are replaced with the existing README value. (my host info => host, my redis server info => local host)
|
Use Case
Since Redis 6.2, a new fields have been added to the command stats section
Two new fields were added: failed_call, rejected_call.
prior to version 6.2
version 6.2 and later
It would be useful to track which commands failed or were rejected.
Expected behavior
Extended commandstats metrics are collected
Actual behavior
No metrics related to errorstats are collected
Additional info
since the new fields are of the same type as the existing
usec
(long long int),I think we can just add a condition to the case statement and be done with it.
then I can get a metrics like below
The text was updated successfully, but these errors were encountered: