Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modbus - Add FLOAT16 data type #11907

Closed
dfousek opened this issue Sep 29, 2022 · 5 comments · Fixed by #12340
Closed

Modbus - Add FLOAT16 data type #11907

dfousek opened this issue Sep 29, 2022 · 5 comments · Fixed by #12340
Assignees
Labels
area/modbus feature request Requests for new plugin and for new features to existing plugins

Comments

@dfousek
Copy link

dfousek commented Sep 29, 2022

Use Case

Hi !
I want to implement InfluxDB/Telegraf communication using a MorningStarCorp's Solar Charger that uses FLOAT16 (!!) data types. Up to now, I need to pass through LabVIEW routines mainly to perform this FLOAT16-FLOAT32 conversions.

Having searched a bit, it appears that is is not uncommon and indeed there is also a standard for it (IEEE 754) https://en.wikipedia.org/wiki/Half-precision_floating-point_format

Note that at the end of the MorningStar document, there are conversion code examples (C, Javascript)

I would very much appreciate this addition to Telegraf/Modbus
Thanks in advance
Dimitri

technical-doc-prostar-mppt-modbus-specification-en.pdf

Expected behavior

Introduce FLOAT16 data type

Actual behavior

No equivalent data type

Additional info

Stick to: IEEE 754 floating numbers format.
https://en.wikipedia.org/wiki/Half-precision_floating-point_format

@dfousek dfousek added the feature request Requests for new plugin and for new features to existing plugins label Sep 29, 2022
@srebhan
Copy link
Member

srebhan commented Sep 29, 2022

@dfousek any chance you submit a PR?

@dfousek
Copy link
Author

dfousek commented Sep 29, 2022

Sven, what's PR ?

@srebhan
Copy link
Member

srebhan commented Sep 30, 2022

It is a pull-request, i.e. you implement that new feature and we will add it to Telegraf after review. Here is some documentation on pull requests: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests

@srebhan srebhan self-assigned this Sep 30, 2022
@dfousek
Copy link
Author

dfousek commented Oct 1, 2022

Sven, this is a feature request to the developers. I don't have the knowledge to do it.

@srebhan
Copy link
Member

srebhan commented Dec 6, 2022

@dfousek can you please test PR #12340 and let me know if this fixes your problem!? You may want to use the binary built by CI which will be available after all tests passed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants