internet_speed configuration options #10656
Comments
|
Hi, When there is an error in a plugin that occurs, it ends the collection attempt. This makes a lot or more sense when you are trying to connect to a database for example and if the initial connect fails, there is no use in going on. In the case of the internet speed plugin, I can see the desire to try to collect download speed if the upload speed test fails and vis versa. When you said it could be an issue with your ISP, or the Speedtest server you are reaching out to in both cases wouldn't we fail the same way with some sort of error about networking?
How many of each issue are you seeing? I am curious to learn what the error rate is for fails on latency versus fails on download/upload. I have run it over a 24-hour period, and minus some issues in #9852 which should be fixed or more limited due to the recent #10530, I have not seen really any failures. Might be worth running with a nightly build as well to get a sense for failure rate. Also how often are you running the plugin? I have seen issues where one run tops another run. Thanks! |
In case my ISP has problems, I would get a timeout because the response doesnt get back to me. If speedtest had some reason to terminate the connection, they would actively send a response with the info, e.g. terminating the connection.
I was not aware of this, thank you. I think this would limit my issues massively.
I was running the plugin every 9mins. If you tell me how to measure the failure rates, I will do it. At the moment I have no idea how to distinguish between the different errors I was seeing during |
|
If you could try the nightly images I linked to that would be good, I'd be curious to see how many error messages even show up. Can you please run Telegraf with: Thanks! |
|
I started it right now. Here is some preview of the first round: I will deliver the rest tomorrow. |
|
Here it comes. About 20 hours. I filtered to just the errors (E!). If this is not sufficient, hit me up and I will post everything. |
|
Did you do this with the nightly builds? And if so did you enable the cache option?
As you originally pointed out this error message is known and is covered by #9852. The root cause is the underlying library and the fix in #10530 should help prevent those from showing up going forward assuming you enabled the option to caches the results. All the other errors seem to be centered around the upload test after the ping and download tests have already been completed:
Of the proposed solutions in your original post:
this probably makes the most sense. I can see us re-trying once but after that throwing an error in the event of some sort of network blip. I am not a fan of only reporting some of the metrics either as that could hide a real issue or cause confusion with users as to why some data shows up and others does not. If you agree, I think the next step then is to add a retry around the 3 three tests in the event of an error. |
|
Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you! |
Feature Request
Opening a feature request kicks off a discussion.
Proposal:
Adding more configuration options, e.g.:
Current behavior:
If one of the three checks fails, nothing gets written to the Bucket.
Desired behavior:
If anything fails, I still want to have the information already gathered or still able to gather. Additionally I want to use a latency-fallback-mode.
Use case:
The speed test is based on Speedtest by Ookla. Regularly this happens: #9852, sometimes, this happens:
Scenario 1: Step 1 (Download) fails
Maybe it is an issue with my ISP or an issue with Speedtest by Ookla. Each following steps (Upload and latency) arent executed. I still want to know.
Scenario 2: Step 2 or 3 (Upload or latency) fails
Maybe it is an issue with my ISP or an issue with Speedtest by Ookla. The following step (latency) isnt executed. I still want to know and I still want to have the information already gatherd (download and upload).
Scenario 3: Step 1 fails with the issue mentioned in #9852
A latency check to some ip-address (like in inputs.ping) has to be executed. At the moment, I would need two plugins to know, if my ISP is broken or Speedtest by Ookla.
The text was updated successfully, but these errors were encountered: