Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VectorRepeatValue support for Logical Expressions #4996

Closed
onelson opened this issue Jul 14, 2022 · 2 comments
Closed

VectorRepeatValue support for Logical Expressions #4996

onelson opened this issue Jul 14, 2022 · 2 comments
Assignees

Comments

@onelson
Copy link
Contributor

onelson commented Jul 14, 2022

Work done in #4960 added the new vector support for certain literals, but only properly added the runtime support in binary expressions.

Logical expressions need to be updated to handle VectorRepeatValue. For this to happen, we must first support vectorization of boolean literals.

DOD:

  • boolean literals can be vectorized.
  • logical expressions correctly handle VectorRepeatValue inputs.
@onelson
Copy link
Contributor Author

onelson commented Jul 14, 2022

I've got a draft PR up for this, but don't want to merge until we're closer to getting boolean literals to work with vectorized code. #4998

@onelson onelson changed the title VectorRepeatValue support for expressions other than binary VectorRepeatValue support for Logical Expressions Aug 16, 2022
@onelson
Copy link
Contributor Author

onelson commented Aug 16, 2022

This issue was originally written to track "unknown work" but it looks like the broad strokes of what was needed beyond binary expressions fell into 2 categories:

Rephrasing the description to cover just the logical expression and the prerequisite boolean literal work.

If it all comes together in #4998 we can probably close #4997 as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant