You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we don't have a way to write an end to end (flux acceptance) test which can make assertions about whether or not something in the query was actually vectorized.
Not exactly sure what the good solution for this is, but the closest thing I can think of available today is the API we have for asserting about pushdowns in the plan.
related, but not necessarily on the critical path for this, but it would be interesting to be able to see information about vectorized operations from the profiler.
NOTE: We think the best way to assert about verctorized operations is to leverage the planner rules. This means we want to create/split the map transformation into two, one for row based and one for vectorized operations. Then the planner rule chooses between them when possible. This way enabling/disabling the planner rule controls vectorization. Additionally we can assert about the application of planner rules in tests already.
DOD:
Remove old (i.e. no chunked implementation of map) this code path is currently dead in production because of the feature flag
Split new (i.e. chunked implementation) of map transformation into two transformations, row and vectorized version.
Create planner rule that picks the vectorized map transformation when the vectorized code is available
Add/Update acceptance tests for each vector operation (i.e. logical, comparison, etc) that show correctness of the vectorized version asserting the planner rule was applied.
The text was updated successfully, but these errors were encountered:
Currently we don't have a way to write an end to end (flux acceptance) test which can make assertions about whether or not something in the query was actually vectorized.
Not exactly sure what the good solution for this is, but the closest thing I can think of available today is the API we have for asserting about pushdowns in the plan.
NOTE: We think the best way to assert about verctorized operations is to leverage the planner rules. This means we want to create/split the map transformation into two, one for row based and one for vectorized operations. Then the planner rule chooses between them when possible. This way enabling/disabling the planner rule controls vectorization. Additionally we can assert about the application of planner rules in tests already.
DOD:
The text was updated successfully, but these errors were encountered: