Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorize remaining arithmetic operators #4586

Closed
onelson opened this issue Mar 22, 2022 · 0 comments · Fixed by #4688
Closed

Vectorize remaining arithmetic operators #4586

onelson opened this issue Mar 22, 2022 · 0 comments · Fixed by #4688
Assignees

Comments

@onelson
Copy link
Contributor

onelson commented Mar 22, 2022

Following on from #4585, #4587 which will have selected a single operator to vectorize from the following list:

  • multiplication
  • division
  • modulo
  • power
  • addition
  • subtraction

The work here is to vectorize the remaining items in the list.

Note that addition has higher complexity than the rest since we overload it for string concatenation. This means it may require extra effort to deliver compared to the rest.

DOD:

  • provide a vectorized implementation of the remaining operators
  • guard the implementation(s) with a feature flag
  • temporary vectors for intermediate results need to be created and destroyed. (i.e. a * b * c the a * b temp vector needs to be created and destroyed after its consumed)
  • Add Flux acceptance tests that hard codes the feature flag on to ensure we still have correctness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants