Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

np.bool8 is deprecated #829

Closed
JHopeCollins opened this issue Mar 1, 2024 · 2 comments · Fixed by #831
Closed

np.bool8 is deprecated #829

JHopeCollins opened this issue Mar 1, 2024 · 2 comments · Fixed by #831

Comments

@JHopeCollins
Copy link

JHopeCollins commented Mar 1, 2024 •
edited
Loading

This type was deprecated in NumPy 1.24 in favour of bool_, but loopy still uses it because the loopy/target/c/compyte is pinned to a 3 year old commit in compyte so DeprecationWarnings are raised in a lot of firedrake scripts.

Is there any reason why this link can't be updated to a more/most recent compyte?
@inducer inducer mentioned this issue Mar 1, 2024
Merged
@inducer
Copy link
Owner

inducer commented Mar 1, 2024

Thanks for the note. AFAIK there are no obstacles to updating compyte, other than it hasn't been done yet. See #831.

@JHopeCollins
Copy link
Author

Thanks for fixing that so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update compyte to d4549d4c711513e2cc098d3f5d4e918eac53ee7a inducer/loopy
2 participants
@inducer @JHopeCollins