Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] avoid overriding continueAsNew threshold when providing workflowConfig (IWF-254) #457

Closed
longquanzheng opened this issue Oct 17, 2024 · 0 comments · Fixed by #478
Closed

Comments

@longquanzheng
Copy link
Contributor

The continueAsNew threshold is 0 (meaning no continueAsNew) when the workflowConfig is not provided: https://github.com/indeedeng/iwf/blob/main/service/interpreter/continueAsNewCounter.go#L48

In current code, when start API provides a configOverride, it will not use the default config, which is 100 threshold: https://github.com/indeedeng/iwf/blob/main/service/api/service.go#L109

We should fix that because when user provide the configOverride, they don't mean to override everthing. They should only override based on the default config --> e.g. the activityOptimization. The override logic should be similar to https://github.com/indeedeng/iwf/blob/main/service/interpreter/workflowConfiger.go#L26

@mixydubs mixydubs changed the title [bug] avoid overriding continueAsNew threshold when providing workflowConfig [bug] avoid overriding continueAsNew threshold when providing workflowConfig (IWF-254) Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant