You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The text was updated successfully, but these errors were encountered:
mixydubs
changed the title
[bug] avoid overriding continueAsNew threshold when providing workflowConfig
[bug] avoid overriding continueAsNew threshold when providing workflowConfig (IWF-254)
Oct 31, 2024
The continueAsNew threshold is 0 (meaning no continueAsNew) when the workflowConfig is not provided: https://github.com/indeedeng/iwf/blob/main/service/interpreter/continueAsNewCounter.go#L48
In current code, when start API provides a configOverride, it will not use the default config, which is 100 threshold: https://github.com/indeedeng/iwf/blob/main/service/api/service.go#L109
We should fix that because when user provide the configOverride, they don't mean to override everthing. They should only override based on the default config --> e.g. the activityOptimization. The override logic should be similar to https://github.com/indeedeng/iwf/blob/main/service/interpreter/workflowConfiger.go#L26
The text was updated successfully, but these errors were encountered: