Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable executingStateIds system search attributes for only states that have waitUntil #411

Closed
longquanzheng opened this issue Aug 9, 2024 · 0 comments · Fixed by #453
Closed

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Aug 9, 2024

The current executingStateIds is too expensive when setting the SA value for every state -- where most states don't have waitUntil and will get passed very quickly.

Mostly, 99% the cases, people only need it when a state has a waitUntil.

This will be very handy to find the states that are waiting on something. Knowing these states will help removing the code.

Ideally, the options to provide to client (via WorkflowConfig)

  • Enable it for any state (even doesn't have waitUntil)
  • Enable it only for state that has waitUntil (preferred as default)
  • Disable (right now this is default for internal)
@longquanzheng longquanzheng changed the title Allow enable executing state id system search attributes for state with wait until only Enable executing state id system search attributes for state with wait until only Sep 11, 2024
@longquanzheng longquanzheng changed the title Enable executing state id system search attributes for state with wait until only Enable executingSateIds system search attributes for only states that have waitUntil Sep 11, 2024
@lwolczynski lwolczynski self-assigned this Oct 14, 2024
@lwolczynski lwolczynski changed the title Enable executingSateIds system search attributes for only states that have waitUntil Enable executingStateIds system search attributes for only states that have waitUntil Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants