From 6c47f1b5714b226b9f7679f6a322874a28f63fc6 Mon Sep 17 00:00:00 2001 From: Steven Harrison <33328989+stevo89519@users.noreply.github.com> Date: Wed, 25 Sep 2024 11:38:12 -0400 Subject: [PATCH] IWF-106: Fix typo IdReusePolicy of ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY (#430) --- gen/iwfidl/api/openapi.yaml | 3 ++- gen/iwfidl/docs/IDReusePolicy.md | 4 +++- gen/iwfidl/model_id_reuse_policy.go | 6 ++++-- service/common/compatibility/workflowStartOptions.go | 3 ++- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/gen/iwfidl/api/openapi.yaml b/gen/iwfidl/api/openapi.yaml index 421dec52..9f15a792 100644 --- a/gen/iwfidl/api/openapi.yaml +++ b/gen/iwfidl/api/openapi.yaml @@ -702,7 +702,8 @@ components: type: string IDReusePolicy: enum: - - ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY + - ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY # Keeping typo enum for backwards compatibility + - ALLOW_IF_PREVIOUS_EXITS_ABNORMALLY - ALLOW_IF_NO_RUNNING - DISALLOW_REUSE - ALLOW_TERMINATE_IF_RUNNING diff --git a/gen/iwfidl/docs/IDReusePolicy.md b/gen/iwfidl/docs/IDReusePolicy.md index 1e9d1932..26f4875b 100644 --- a/gen/iwfidl/docs/IDReusePolicy.md +++ b/gen/iwfidl/docs/IDReusePolicy.md @@ -2,9 +2,11 @@ ## Enum - +# Keeping typo enum for backwards compatibility * `ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY` (value: `"ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY"`) +* `ALLOW_IF_PREVIOUS_EXITS_ABNORMALLY` (value: `"ALLOW_IF_PREVIOUS_EXITS_ABNORMALLY"`) + * `ALLOW_IF_NO_RUNNING` (value: `"ALLOW_IF_NO_RUNNING"`) * `DISALLOW_REUSE` (value: `"DISALLOW_REUSE"`) diff --git a/gen/iwfidl/model_id_reuse_policy.go b/gen/iwfidl/model_id_reuse_policy.go index 9d46426f..dbb23918 100644 --- a/gen/iwfidl/model_id_reuse_policy.go +++ b/gen/iwfidl/model_id_reuse_policy.go @@ -20,7 +20,8 @@ type IDReusePolicy string // List of IDReusePolicy const ( - ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY IDReusePolicy = "ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY" + ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY IDReusePolicy = "ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY" // Keeping typo enum for backwards compatibility + ALLOW_IF_PREVIOUS_EXITS_ABNORMALLY IDReusePolicy = "ALLOW_IF_PREVIOUS_EXITS_ABNORMALLY" ALLOW_IF_NO_RUNNING IDReusePolicy = "ALLOW_IF_NO_RUNNING" DISALLOW_REUSE IDReusePolicy = "DISALLOW_REUSE" ALLOW_TERMINATE_IF_RUNNING IDReusePolicy = "ALLOW_TERMINATE_IF_RUNNING" @@ -28,7 +29,8 @@ const ( // All allowed values of IDReusePolicy enum var AllowedIDReusePolicyEnumValues = []IDReusePolicy{ - "ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY", + "ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY", // Keeping typo enum for backwards compatibility + "ALLOW_IF_PREVIOUS_EXITS_ABNORMALLY", "ALLOW_IF_NO_RUNNING", "DISALLOW_REUSE", "ALLOW_TERMINATE_IF_RUNNING", diff --git a/service/common/compatibility/workflowStartOptions.go b/service/common/compatibility/workflowStartOptions.go index 60c31e56..c3079a1e 100644 --- a/service/common/compatibility/workflowStartOptions.go +++ b/service/common/compatibility/workflowStartOptions.go @@ -10,7 +10,8 @@ func GetWorkflowIdReusePolicy(options iwfidl.WorkflowStartOptions) *iwfidl.Workf switch newType { case iwfidl.ALLOW_IF_NO_RUNNING: return iwfidl.ALLOW_DUPLICATE.Ptr() - case iwfidl.ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY: + case iwfidl.ALLOW_IF_PREVIOUS_EXISTS_ABNORMALLY, iwfidl.ALLOW_IF_PREVIOUS_EXITS_ABNORMALLY: + // Keeping typo enum for backwards compatibility. Both old and corrected enums return the same result. return iwfidl.ALLOW_DUPLICATE_FAILED_ONLY.Ptr() case iwfidl.DISALLOW_REUSE: return iwfidl.REJECT_DUPLICATE.Ptr()