Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a hex package #7

Closed
1 of 3 tasks
Licenser opened this issue Nov 26, 2015 · 6 comments
Closed
1 of 3 tasks

provide a hex package #7

Licenser opened this issue Nov 26, 2015 · 6 comments

Comments

@Licenser
Copy link
Contributor

This requires the dependencies to be availalbe via hex too
Regarding this I already opened:

Once they are closed we should be able to use them in deps and use rebar3 hex upload to generate a elvis_core hex package :D

@elbrujohalcon
Copy link
Member

I would be much happier if we could add hex.pm integration to erlang.mk … but for know, we can do it the rebar3 way

@Licenser
Copy link
Contributor Author

This is more a requirement of hex then of rebar3, hex packages can't specify dependencies that are not packages themselves. What tool uploads them, rebar, mix, erlang.mk or some curl doesn't matter.

@tsloughter
Copy link

Right, it doesn't matter what tool is used to publish to hex, all that matters is that all dependencies are in hex. Publishing with rebar3 or mix (or any other tool that gets support) is fine.

@jfacorro
Copy link
Contributor

Is it really necessary to have all dependencies in hex? Doesn't it depend on what tool is used to build the project. For example, if I'm building my project with make (using erlang.mk) and elvis_core is a dep that we get from hex.pm, erlang.mk will download its package and try to build it, since it has a Makefile with its own deps everything should work. I imagine the same scenario is valid when using rebar, rebar3 or mix as long as the package contains a rebar.config file. Am I wrong?

@tsloughter
Copy link

Rebar3 resolves all deps of a hex package based on the registry, it will not fetch additional deps that are defined in rebar.config.

@jfacorro
Copy link
Contributor

@tsloughter Oh, I see. I didn't know that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants