Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution without elvis.config shows no issues #163

Closed
paulo-ferraz-oliveira opened this issue Sep 18, 2020 · 6 comments
Closed

Execution without elvis.config shows no issues #163

paulo-ferraz-oliveira opened this issue Sep 18, 2020 · 6 comments

Comments

@paulo-ferraz-oliveira
Copy link
Collaborator

I just created a new project, added no elvis.config to it, ran elvis on top of it and... got no issues.

I was assuming a default elvis.config would be applied.

Is there a preference here? Or is this a non-issue?

rebar3_lint does implement its own default, but it'll easily be outdated (or "wrong", if it's aiming at elvis' defaults - e.g. nesting_level default is now 4, not 3).

@Licenser, any thoughts on this?

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Should this be kept open? Is it something we want to take care of? We'd remove the need to sync. changes in the defaults, for example, from elvis to rebar3_lint.

@elbrujohalcon
Copy link
Member

I think that elvis_core should be the place to keep the defaults, but I'm not sure this is a pressing issue right now. However, I don't have enough data to know how many people uses elvis as a standalone script vs. how many people uses elvis_core through rebar_lint.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I used to use elvis as a standalone script until I found out about the plugin. In any case, if there's defaults in elvis_core (for an empty/non-existing elvis.config) this means that rebar3_lint has only to import a new version, at every release (well, until @Licenser decides to implement specific options, that is 😄).

@Licenser
Copy link
Contributor

Licenser commented Oct 1, 2020

I'm not actively changing rebar3_lint but I'm more then happy to merge any PR that improves it's behavior :)

@paulo-ferraz-oliveira paulo-ferraz-oliveira self-assigned this Oct 3, 2020
@elbrujohalcon
Copy link
Member

Is this solved already, @paulo-ferraz-oliveira ?

@elbrujohalcon elbrujohalcon transferred this issue from inaka/elvis Jan 7, 2021
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Two things:

  1. I'm not actively using the CLI elvis anymore, but assume the issue hasn't been fixed (I saw nothing in my notifications that pointed to it),
  2. I still would like rebar3_lint to not assume any defaults (and leave that to elvis_core), but that's an issue for a different repo (I went to check it, and you've solved it already, hurrah!).

I think it's safe to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants