Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--version / -V no longer working #295

Closed
danie-dejager opened this issue Sep 25, 2023 · 4 comments
Closed

--version / -V no longer working #295

danie-dejager opened this issue Sep 25, 2023 · 4 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@danie-dejager
Copy link

I can no longer get the installed version by running bandwhich -V or with --version. I use this to upgrade to newer versions.

image

This used to work for v 0.20.0.

@edvardsanta
Copy link

Hello, this problem was already solved in #290, release 0.21.0 has version again =].
image

@danie-dejager
Copy link
Author

danie-dejager commented Sep 28, 2023

Do you compile it differently to set the version? I just downloaded bandwhich-v0.21.0-x86_64-unknown-linux-musl.tar.gz from the releases and from that binary I don't get the version:

./bandwhich --version
error: unexpected argument '--version' found

Usage: bandwhich [OPTIONS]

For more information, try '--help'.

I built mine from source:
cargo build --release
I also built using the src rpm on COPR. There is no version output.

@edvardsanta
Copy link

edvardsanta commented Sep 28, 2023

i built mine from source too, i will clone the repo again to test.

Edit: in the main branch it's working and in the release tag v0.21.0 it's not really working.
image
As you can see, v0.21.0 has no version yet, it will probably be fixed in the next version. Sorry for my previous analysis

@cyqsimon cyqsimon added bug Something isn't working duplicate This issue or pull request already exists labels Oct 6, 2023
@cyqsimon
Copy link
Collaborator

cyqsimon commented Oct 6, 2023

Thanks for the report. This was an accidental omission and has been fixed in main. See #290. I will close this as duplicate of #292.

@cyqsimon cyqsimon closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants