diff --git a/.github/PULL_REQUEST_TEMPLATE/config.yml b/.github/PULL_REQUEST_TEMPLATE/config.yml index 6663b04cbc63f..4172e3df95270 100644 --- a/.github/PULL_REQUEST_TEMPLATE/config.yml +++ b/.github/PULL_REQUEST_TEMPLATE/config.yml @@ -1,2 +1 @@ -blank_issues_enabled: false blank_pull_request_template_enabled: false diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md deleted file mode 100644 index 83a365eab9d8e..0000000000000 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ /dev/null @@ -1,22 +0,0 @@ -## Description - - - - -Fixes # (issue) - - -## How Has This Been Tested? - - - -- [ ] Test A -- [ ] Test B - -## Screenshots (if appropriate): - - -## Checklist: - -- [ ] I have performed a self-review of my own code -- [ ] I have made corresponding changes to the documentation if applicable \ No newline at end of file diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000000..5d4290fd7bdb9 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,36 @@ +## Description + + + + + +Fixes # (issue) + +## How Has This Been Tested? + + + +- [ ] Test A +- [ ] Test B + +

Screenshots (if appropriate)

+ + + +
+ + + +## Checklist: + +- [ ] I have performed a self-review of my own code +- [ ] I have made corresponding changes to the documentation if applicable +- [ ] I have no unrelated changes in the PR. +- [ ] I have confirmed that any new dependencies are strictly necessary. +- [ ] I have written tests for new code (if applicable) +- [ ] I have followed naming conventions/patterns in the surrounding code +- [ ] All code in `src/services` uses repositories implementations for database calls, filesystem operations, etc. +- [ ] All code in `src/repositories/` is pretty basic/simple and does not have any immich specific logic (that belongs in `src/services`)