Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile UI showing many English texts instead of translation #13477

Closed
1 of 3 tasks
Sherlock1979 opened this issue Oct 15, 2024 · 7 comments
Closed
1 of 3 tasks

Mobile UI showing many English texts instead of translation #13477

Sherlock1979 opened this issue Oct 15, 2024 · 7 comments

Comments

@Sherlock1979
Copy link

The bug

Looking at the new UI changes in 1.118 in a different language I noticed that half of the UI is now in English. My app language is set to Hungarian which is 100% translated. (I am one of the translators and reviewed and improved the whole translation to make it consistent and fix up glitches and typos.)

Anyways, couple of examples in the attached screenshots.

Screenshot_20241016-070107
Screenshot_20241016-070036
Screenshot_20241016-065938
Screenshot_20241016-065900
Screenshot_20241016-065805
Screenshot_20241016-065731
Screenshot_20241016-065528

Thanks for looking into it.

The OS that Immich Server is running on

Ubuntu 24.04

Version of Immich Server

1.118.0

Version of Immich Mobile App

1.118.0 build.163

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

Irrelevant

Your .env content

Irrelevant

Reproduction steps

  1. Open Immich android app.
  2. Change language (e.g., to Hungarian)
  3. Optional: force stop and start the app again
  4. Observe the lack of translated texts.

Relevant log output

No response

Additional information

No response

@bo0tzz
Copy link
Member

bo0tzz commented Oct 15, 2024

#12582 added new translation keys when updating those pages, which I think is what you're seeing here. Are you sure those were translated before we started this release?

@alextran1502
Copy link
Contributor

The keys were changed so they need to be updated from Localizely as well

@Sherlock1979
Copy link
Author

#12582 added new translation keys when updating those pages, which I think is what you're seeing here. Are you sure those were translated before we started this release?

Yes, the Hungarian translation was always very up-to-date and I spent this weekend reviewing the whole translation. It was fully translated by Sunday, including any new translation keys.

Also note that many of those missing texts are not new translation keys.

Thanks.

@Sherlock1979
Copy link
Author

The keys were changed so they need to be updated from Localizely as well

Sorry, I don't understand. Can you please clarify? Do we still use Localizely as well? I assumed we fully moved on to weblate. 😮

@bo0tzz
Copy link
Member

bo0tzz commented Oct 15, 2024

The mobile app is still on localizely 😅

@Sherlock1979
Copy link
Author

The mobile app is still on localizely 😅

Oh no, that's terrible. I mean I can definitely look into it but it's a lot of duplicated effort to keep both translations up-to-date as well as consistent.

Do you have any plans to move all translations over to a single repository?

Also note that the dates/times are in English as well. I think that's not a translation issue but the app would need to apply the relevant locale to date formatting functions.

Cheers

@Sherlock1979
Copy link
Author

Done, I have reviewed and updated the Hungarian localizely translation, and added all missing keys. @alextran1502, can you please include the changes in the next release? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants