diff --git a/Gopkg.lock b/Gopkg.lock index 492f172bd1f..b264b39da12 100644 --- a/Gopkg.lock +++ b/Gopkg.lock @@ -589,11 +589,12 @@ version = "v1.0.3" [[projects]] - digest = "1:5558ceef0c045f9c8a0c08c6e0de89bb0895b1aad69d9722b3748f003564b8cb" + branch = "master" + digest = "1:52353264b6df3bd5c5da47f84904456a0c81f7f59d224b4da9675d0dc78bbf3e" name = "github.com/tektoncd/plumbing" packages = ["scripts"] pruneopts = "UT" - revision = "a51e87c5261fdb718470c077c155e070aca690a8" + revision = "933f0722e02cf10a891027381ba8a01ac4c8530e" [[projects]] digest = "1:b7d98c64e9467a8e5e67509031cd6baee81fba090ba2c3d30df1ff3d02d1d035" diff --git a/Gopkg.toml b/Gopkg.toml index 399a26835dc..fe7251d2c51 100644 --- a/Gopkg.toml +++ b/Gopkg.toml @@ -72,11 +72,6 @@ required = [ # HEAD as of 2019-07-23 revision = "2032732871ff807958e045858b462d372eec9587" -[[constraint]] - name = "github.com/tektoncd/plumbing" - # HEAD as of 2019-06-24 - revision = "a51e87c5261fdb718470c077c155e070aca690a8" - [[constraint]] name = "github.com/knative/test-infra" # HEAD as of 2019-06-25 diff --git a/vendor/github.com/tektoncd/plumbing/scripts/library.sh b/vendor/github.com/tektoncd/plumbing/scripts/library.sh index 5f2e287e920..1d216fe6739 100755 --- a/vendor/github.com/tektoncd/plumbing/scripts/library.sh +++ b/vendor/github.com/tektoncd/plumbing/scripts/library.sh @@ -310,23 +310,6 @@ function report_go_test() { return ${failed} } -# Install the latest stable Tekton/serving in the current cluster. -function start_latest_tekton_serving() { - header "Starting Tekton Serving" - subheader "Installing Istio" - echo "Running Istio CRD from ${TEKTON_ISTIO_CRD_YAML}" - kubectl apply -f ${TEKTON_ISTIO_CRD_YAML} || return 1 - wait_until_batch_job_complete istio-system || return 1 - echo "Installing Istio from ${TEKTON_ISTIO_YAML}" - kubectl apply -f ${TEKTON_ISTIO_YAML} || return 1 - wait_until_pods_running istio-system || return 1 - kubectl label namespace default istio-injection=enabled || return 1 - subheader "Installing Tekton Serving" - echo "Installing Serving from ${TEKTON_SERVING_RELEASE}" - kubectl apply -f ${TEKTON_SERVING_RELEASE} || return 1 - wait_until_pods_running tekton-serving || return 1 -} - # Run a go tool, installing it first if necessary. # Parameters: $1 - tool package/dir for go get/install. # $2 - tool to run. diff --git a/vendor/github.com/tektoncd/plumbing/scripts/presubmit-tests.sh b/vendor/github.com/tektoncd/plumbing/scripts/presubmit-tests.sh index afed176050d..742240b8b13 100755 --- a/vendor/github.com/tektoncd/plumbing/scripts/presubmit-tests.sh +++ b/vendor/github.com/tektoncd/plumbing/scripts/presubmit-tests.sh @@ -130,12 +130,20 @@ function markdown_build_tests() { } # Default build test runner that: +# * check go code style with gofmt # * check markdown files # * `go build` on the entire repo # * run `/hack/verify-codegen.sh` (if it exists) # * check licenses in all go packages function default_build_test_runner() { local failed=0 + # Check go code style with gofmt; exclude vendor/ files + subheader "Checking go code style with gofmt" + gofmt_out=$(gofmt -d $(find * -name '*.go' ! -path 'vendor/*')) + if [[ -n "$gofmt_out" ]]; then + failed=1 + fi + echo "$gofmt_out" # Perform markdown build checks first markdown_build_tests || failed=1 # For documentation PRs, just check the md files