Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignite apps can panic on chain get when running inside a Go module #3968

Closed
jeronimoalbi opened this issue Feb 14, 2024 · 1 comment · Fixed by #3969
Closed

Ignite apps can panic on chain get when running inside a Go module #3968

jeronimoalbi opened this issue Feb 14, 2024 · 1 comment · Fixed by #3969
Assignees
Labels
component:apps Related to Ignite Apps. type:error Something isn't working

Comments

@jeronimoalbi
Copy link
Member

Ignite apps that access the chain instance through the client API die when running from a directory that contains a Go module and a Git repository because that directory is considered a valid app chain.

The error is triggered when accessing the first validator, which is mandatory, which in this case is not configured because the default configuration is used before a validator is initialized. The default config is used because a directory with a go.mod and a .git folder is initially considered an app chain but because it isn't it doesn't contain a config file.

@jeronimoalbi jeronimoalbi added type:error Something isn't working component:apps Related to Ignite Apps. labels Feb 14, 2024
@jeronimoalbi jeronimoalbi self-assigned this Feb 14, 2024
@jeronimoalbi jeronimoalbi moved this from Backlog to In Progress in Ignite CLI Masterboard Feb 14, 2024
@jeronimoalbi jeronimoalbi changed the title Ignite apps panic on chain get when running inside a Go module Ignite apps can panic on chain get when running inside a Go module Feb 14, 2024
@jeronimoalbi
Copy link
Member Author

This issue won't commonly happen, but it should be fixed so this case is handled without generating a panic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:apps Related to Ignite Apps. type:error Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant