Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serve: output makes it hard to copy/paste mnemonic #3363

Closed
fadeev opened this issue Jan 4, 2023 · 2 comments · Fixed by #3522
Closed

serve: output makes it hard to copy/paste mnemonic #3363

fadeev opened this issue Jan 4, 2023 · 2 comments · Fixed by #3522
Labels
component:design Design or UX improvements good first issue Good for newcomers proposal

Comments

@fadeev
Copy link
Contributor

fadeev commented Jan 4, 2023

The left whitespace indentation makes it hard to copy and then properly paste the mnemonic into Keplr or any other app.

Screenshot 2023-01-04 at 14 15 34

I propose we:

  • remove whitespace indentation from the left-hand side
  • stop wrapping mnemonics
~/example ignite c serve -r

Blockchain is running
  
Added account alice with address cosmos193heencxca2vgxkwrzev6qnzz0fswhc5yu5f3v and mnemonic:
person estate daughter box chimney clay bronze ring story truck make excess ring frame desk start food leader sleep predict item rifle stem boy                  
  
Added account bob with address cosmos1qx8qddmrljm0wrcjd07khtfpqlys6ge2wnrjgt and mnemonic:
stick farm pelican coast robust fault ecology hospital noodle venue noise around limit spoon broken twelve shrug intact mass entry wasp crowd police weapon      
  
Added account frank with address cosmos1k2m58vv732yjrs6pnhaf3ar8dtwdql5mlcv478 and mnemonic:
struggle since inmate safe logic kite tag web win stay security wonder
  
🌍 Tendermint node: http://0.0.0.0:26657
🌍 Blockchain API: http://0.0.0.0:1317
🌍 Token faucet: http://0.0.0.0:4500
  
⋆ Data directory: /Users/fadeev/.example
⋆ App binary: /Users/fadeev/go/bin/exampled
  
Press the 'q' key to stop serve
@fadeev fadeev added good first issue Good for newcomers proposal component:design Design or UX improvements labels Jan 4, 2023
@scottcarterco
Copy link
Contributor

Noticing that the formatting has a green checkmark to show that the task completed successfully, it seems like your proposed stop wrapping mnemonics would complete your goal while maintaining the visual cue that account was added. Thoughts?

@derickmr
Copy link
Contributor

derickmr commented May 9, 2023

hey @fadeev, @aljo242, I'd like to contribute to the project and this issue seems to be a good one to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:design Design or UX improvements good first issue Good for newcomers proposal
Projects
None yet
3 participants