Unify error wrapping

[aljo242]

Context

Summary

We have inconsistent use of error wrapping throughout the codebase, mainly a mix between:

• fmt.Errorf()
• errors.Wrap() from pkg/errors

It makes sense to just choose one of these ways of handling errors. From the discussion on discord, there are advantages in using errors.Wrap() as it includes a stack trace to be optionally displayed to users - helpful for debugging.

pkg/errors is now archived and no longer maintained, so there is another project, https://github.com/cockroachdb/errors, that is currently maintained and is a drop-in replacement with some added functionality.

[jeronimoalbi]

Are there any other benefits for the CLI of not using the standard Go errors? I mean, beyond the stack trace support.

If the only real benefit is just the stack trace support and we decide is something really helpful maybe we could just implement it ourselves instead of adding a dependency for that.

Alternatively wrapping errors coming from Go stdlib, third party packages and ignite/pkg might be enough to be a good solution.

[DimitrisJim]

Alternatively wrapping errors coming from Go stdlib, third party packages and ignite/pkg might be enough to be a good solution.

on this, wrapcheck could be of use.

[aljo242]

So, after discussing, the team will looking to unify error handling with using fmt.Errorf() throughout the code.

This is correct right?

[jeronimoalbi]

So, after discussing, the team will looking to unify error handling with using fmt.Errorf() throughout the code.

This is correct right?

As far as I know. Lets wait for @tbruyelle confirmation.