Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate ts-client: generate TS clients for all modules by default #3122

Closed
emidev98 opened this issue Nov 15, 2022 · 5 comments · Fixed by #3331
Closed

generate ts-client: generate TS clients for all modules by default #3122

emidev98 opened this issue Nov 15, 2022 · 5 comments · Fixed by #3331
Assignees
Milestone

Comments

@emidev98
Copy link

When scaffolding a new chain or using the command ignite generate ts-client it creates the ts-client folder with the models from the proto directory but does not generate the cosmos or ibc clients that are imported anyway by default in the generated typescript application.

To reproduce

$ ignite scaffold chain hello # you can check the ts-client folder and it will have correctly imported the types for the current project but not the default cosmos or ibc types
$ cd hello
$ ignite generate ts-client

Result after running the command ignite generate ts-client:
image

Ignite version?

Ignite CLI version:     v0.25.1
Ignite CLI build date:  2022-10-20T15:52:00Z
Ignite CLI source hash: cc393a9b59a8792b256432fafb472e5ac0738f7c
Cosmos SDK version:     v0.46.3
Your OS:                linux
Your arch:              amd64
Your Node.js version:   v18.12.1
Your go version:        go version go1.18.7 linux/amd64
Your uname -a:          Linux WorkInProgress 5.19.0-16.4-liquorix-amd64 #1 ZEN SMP PREEMPT_DYNAMIC liquorix 5.19-26ubuntu1~focal (2022-1 x86_64 x86_64 x86_64 GNU/Linux
Your cwd:               /home/emi/Documents/github/hello
Is on Gitpod:           false
@emidev98 emidev98 added the type:error Something isn't working label Nov 15, 2022
@fadeev fadeev changed the title Ignite generate ts-client generate ts-client: generate TS clients for all modules by default Nov 28, 2022
@fadeev
Copy link
Contributor

fadeev commented Nov 28, 2022

Right now to generate code for all modules one has to run the following command:

ignite generate ts-client --clear-cache

I propose we generate code for all modules (including the standard ones) by default without any flags.

@fadeev fadeev added component:ts-client and removed type:error Something isn't working labels Nov 28, 2022
@fadeev
Copy link
Contributor

fadeev commented Dec 13, 2022

@aljo242 I propose we add this to v0.26 #3274

@aljo242 aljo242 added this to the v0.26.0 milestone Dec 13, 2022
@aljo242
Copy link
Contributor

aljo242 commented Dec 16, 2022

@clockworkgr do you think you can fit this in before the new release?

@clockworkgr
Copy link
Collaborator

@aljo242 I can try? but this is on the go side of things....I think @jeronimoalbi already did it for g vuex so may be faster if he has a look?

This is also relevant #3262 and have started a discussion in slack

@jeronimoalbi
Copy link
Member

@aljo242 I can try? but this is on the go side of things....I think @jeronimoalbi already did it for g vuex so may be faster if he has a look?

I will take a look at it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants