Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove placeholders from the template #2841

Open
1 of 5 tasks
Tracked by #3051
fadeev opened this issue Sep 17, 2022 · 7 comments
Open
1 of 5 tasks
Tracked by #3051

Remove placeholders from the template #2841

fadeev opened this issue Sep 17, 2022 · 7 comments
Assignees
Labels
component:scaffold Feature, enhancement, or refactor related to scaffolding. type:refactor

Comments

@fadeev
Copy link
Contributor

fadeev commented Sep 17, 2022

Currently, placeholders exist in the following places in the standard template:

  • app/app.go
  • proto/
    • genesis.proto
    • query.proto
    • tx.proto
  • x/MODULE/
    • client/cli: the next version of the CLI will auto-generate CLI, so removing placeholders from here is not a priority
    • types/
      • codec.go
      • keys.go
      • genesis.go and genesis_test.go
    • genesis.go and genesis_test.go
    • module_simulation.go
  • cmd: should be removed by replacing cosmoscmd with something else

This issue is related to the discussion on Discord:

https://discord.com/channels/893126937067802685/907904892780290058/1020618039647027290

@fadeev fadeev added the component:scaffold Feature, enhancement, or refactor related to scaffolding. label Sep 17, 2022
@DimitrisJim
Copy link
Contributor

DimitrisJim commented Sep 22, 2022

Hey @fadeev, if you don't remember, I was behind the project for addressing this during the 2021 Hackathon.

I haven't really been keeping up to speed with the overall changes but I've been looking for a reason to finish this up and contribute back to the project.

(Note: saw the discussion on the ignite-cli-dev channel on Discord but I guess it is restricted for team-only, lmk if there's a more appropriate place to discuss this)

@fadeev
Copy link
Contributor Author

fadeev commented Sep 22, 2022

Oh, hey, @DimitrisJim! The ignite-cl-dev channel is indeed the best place to discuss this. I've added you to the channel 🙌

@tbruyelle
Copy link
Contributor

Hi @DimitrisJim, have you made any progress on this ? We'd like to move forward so if you don't have the time to work on it, no problem but we need to assign someone else.

@DimitrisJim
Copy link
Contributor

@tbruyelle yes! Had some other issues pop up but I should hopefully get a PR within the week.

@tbruyelle
Copy link
Contributor

awesome !

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Jan 9, 2023

Bump for an FIY, I am working on the second part for this, albeit not at the pace I'd like.

@salmad3
Copy link
Member

salmad3 commented Jan 22, 2025

#4437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:scaffold Feature, enhancement, or refactor related to scaffolding. type:refactor
Projects
Status: Doing
Development

No branches or pull requests

6 participants