Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/network: mv chain reward to reward #2118

Closed
ilgooz opened this issue Feb 23, 2022 · 3 comments · Fixed by #2086
Closed

cmd/network: mv chain reward to reward #2118

ilgooz opened this issue Feb 23, 2022 · 3 comments · Fixed by #2086
Assignees
Milestone

Comments

@ilgooz
Copy link
Member

ilgooz commented Feb 23, 2022

What do you think, it's confusing to have it under the chain namespace because it's mostly about launch.

cc @lubtd @Pantani

@ilgooz ilgooz added this to the T1 milestone Feb 23, 2022
@lumtis
Copy link
Contributor

lumtis commented Feb 24, 2022

Yes, I agree we can have directly network reward if this command has subcommands related to reward, the same as network request

For the because it's mostly about launch. reason, I didn't clearly get it, every command we have in network are related to launch

@ilgooz
Copy link
Member Author

ilgooz commented Feb 24, 2022

Of course they are related but chain command is for launching the chain collaboratively, pretty different comparing to other commands/functionality.

@Pantani
Copy link
Collaborator

Pantani commented Feb 25, 2022

make total sense for me, easier to use and less confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants