Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: upgrade SPN version #1984

Closed
ilgooz opened this issue Jan 11, 2022 · 6 comments · Fixed by #2020
Closed

network: upgrade SPN version #1984

ilgooz opened this issue Jan 11, 2022 · 6 comments · Fixed by #2020
Assignees
@Pantani
Milestone
T1

Comments

@ilgooz
Copy link
Member

ilgooz commented Jan 11, 2022

After merging https://github.com/tendermint/spn/pull/441/files.
@ilgooz ilgooz added this to the Next milestone Jan 11, 2022
@lumtis
Copy link
Contributor

lumtis commented Jan 11, 2022

We must not just update SPN but update the prepare process. Right now it considers all genesis validators contains a simple peer address and try to update config.toml from this

@ilgooz
Copy link
Member Author

ilgooz commented Jan 12, 2022 •
edited
Loading

Yes, but that's tracked by another issue here #1889.

For this issue, we only need to migrate to the new version of the SPN and preserve the existing functionality. Tunnel and Gitpod support will be added by the referenced issue.

@lumtis
Copy link
Contributor

lumtis commented Jan 12, 2022

preserve the existing functionality

Yes, I meant this. The prepare command will fait if spn is updated

@ilgooz
Copy link
Member Author

ilgooz commented Jan 12, 2022

Yes, that's the point. While updating SPN, migration needs to be done.

@ilgooz ilgooz modified the milestones: Next, Network Jan 25, 2022
@ilgooz
Copy link
Member Author

ilgooz commented Jan 25, 2022

@Pantani if there is chance can you give this a priority?

@lumtis
Copy link
Contributor

lumtis commented Jan 25, 2022

FYI: we might have errors because the default chain ID of SPN has been changed from spn to spn-1

@Pantani Pantani mentioned this issue Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pantani Pantani

Labels
None yet
Projects
None yet
Milestone
T1
Development

Successfully merging a pull request may close this issue.

feat(network): update spn version with the new peer structure ignite/cli
3 participants
@Pantani @ilgooz @lumtis