Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vs Extension should NOT build entire solution prior to conversion #816

Closed
fitdev opened this issue Jan 26, 2022 · 5 comments
Closed

Vs Extension should NOT build entire solution prior to conversion #816

fitdev opened this issue Jan 26, 2022 · 5 comments

Comments

@fitdev
Copy link

fitdev commented Jan 26, 2022

Steps to reproduce

  1. Right-click on the vb project in Solution Explorer
  2. Click on Convert to C#

What happens:

Entire solution is being built.

What should happen:

Only the project should be built along with its dependencies. Why? In my case I had a solution with 80+ projects, only 20 of which were related to the project being converted, which moreover was up to date anyways. So the conversion process triggered entire solution rebuilt which was completely unnecessary, and moreover may screw up various things when you do not expect certain projects to be built.

@GrahamTheCoder
Copy link
Member

Sounds reasonable to me. I'll see if I can make converting a single project/document only build the project in question

@fitdev
Copy link
Author

fitdev commented Jan 27, 2022

Thank you for looking into this. If this is too hard, at the least show a warning / messagebox asking whether extension should rebuild the whole solution, or the user would do it manually before attempting the conversion.

@GrahamTheCoder
Copy link
Member

GrahamTheCoder commented Jan 27, 2022

My first attempt to improve this was released this morning, please let me know if updating to 8.4.5.0 improves things for you (or indeed causes any new issues!). The VS DTE APIs are a bit finnicky...

@fitdev
Copy link
Author

fitdev commented Jan 31, 2022

Just tested the new version. It worked really well this time - no solution rebuild was triggered! Thanks for your work!

@GrahamTheCoder
Copy link
Member

Great, thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants