-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins crash when run from icinga2-2.8.3 #6257
Comments
Seems we have that problem too. Returns error code 11 After downgrade to 2.8.2-1 all works as before. |
@olegy89 Also on Oracle? |
@Crunsher centos6, centos7 |
I'm not able to reproduce this on centos7. Can you share your exact Host, Service and CheckCommand object definition? This works fine:
|
Hi, in our case it's the mailq on host is empty
user nagios does the check via plugin manually and it works
icingaweb2 reports
|
We noticed problem only with external command 'sudo exim -bpc' and 'check_ipmi_sensor' plugin.
Result displayed in icinga web: |
@olegy89 Could you run |
Thanks! So it has nothing to do with the kernel sigh |
I am able to reproduce this using @sysadmama 's config example |
@dnsmichi
|
We've isolated the problem and are preparing 2.8.4 which reverts the regression. |
Backported to support/2.8 |
Release is in progress: https://github.com/Icinga/icinga2/blob/master/RELEASE.md |
Thanks for the reports everyone 💪 2.8.4 is published to our package repos.
|
I can confirm, patch is working for check_ipmi_sensor. Thanks ! |
Jup, patch ist working too. Thanks! 🎉 |
hi, just as an information: I had/have the same issue for my nagios-plugins-ceph (check_ceph_*) and check_ipmi. It took me some hours to find it, but going back to 2.8.2-1.stretch solved the problem. |
@linuxmail 2.8.4 has this fixed |
I did a little reading yesterday evening on the faulty patch, and for some technical reference it can be assumed that it changed the way the default stack size was set and handled later. This caused a too low stack size where specific applications/plugins would then crash from in this process/thread space. We've seen a similar thing with the stack guard patches in the RHEL kernel where setting the stack size also failed and made applications crash. That experience, and the only known located change in application.cpp justifies the immediate revert for production. Future patches in this region will be reviewed long-term, and if not properly proven with test protocols, likely not get merged. Cheers, |
Hello @dnsmichi |
@tclh123 Feel free to open another PR. We would like having this fixed but got our hands are full with 2.9.0 |
Such a PR must include a test protocol with and without the patch testing all the edge cases, and requires long term tests. As can be seen, there are more implications with breaking things here. |
We are using Oracle linux (6.9). After upgrading icinga2 today ps that runs from the icinga user crashes.
abrt report
The text was updated successfully, but these errors were encountered: