Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #6589] Command pipe blocks when trying to open it more than once in parallel #1741

Closed
icinga-migration opened this issue Jun 26, 2014 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/6589

Created by gbeutner on 2014-06-26 13:45:47 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2014-08-05 16:05:04 +00:00)
Target Version: 2.0.2
Last Update: 2014-08-05 16:05:04 +00:00 (in Redmine)

Icinga Version: 2.0.0

Changesets

2014-08-05 16:01:01 +00:00 by (unknown) 963125f

ExternalCommandListener: Use threads per client connection

fixes #6589

2014-08-05 16:48:29 +00:00 by (unknown) c01dfdf

Documentation: Add a note on async non-blocking events

refs #6589

2014-08-20 11:45:31 +00:00 by gbeutner e1b8b05

Use threads for external commands

refs #6589
fixes #6942

2014-08-20 21:35:11 +00:00 by gbeutner 0d47685

Fix a potential crash in ExternalCommandListener::CommandPipeThread

refs #6589

Relations:

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-07-09 15:04:34 +00:00

  • Target Version deleted 2.0.1

@icinga-migration
Copy link
Author

Updated by gbeutner on 2014-07-11 07:54:06 +00:00

  • Target Version set to 2.0.2

@icinga-migration
Copy link
Author

Updated by gbeutner on 2014-07-11 09:10:40 +00:00

  • Estimated Hours set to 3

Required changes:

  • Use threads for external commands

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-08-05 16:00:39 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mfriedrich

Test with 2 terminals from "tools/scripts"

# while true; do ./process_check_result -H 6479-keks -r 0 -o "multiple foo 1"; sleep 1; done 

# while true; do ./process_check_result -H 6479-keks -r 1 -o "multiple foo 2"; sleep 1; done 

results in

[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254384] PROCESS_HOST_CHECK_RESULT;6479-keks;0;multiple foo 1
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254383] PROCESS_HOST_CHECK_RESULT;6479-keks;1;multiple foo 2
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254384] PROCESS_HOST_CHECK_RESULT;6479-keks;0;multiple foo 1
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254384] PROCESS_HOST_CHECK_RESULT;6479-keks;0;multiple foo 1
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] notice/ExternalCommandListener: Client connected
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254384] PROCESS_HOST_CHECK_RESULT;6479-keks;1;multiple foo 2
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254379] PROCESS_HOST_CHECK_RESULT;6479-keks;1;multiple foo 2
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254381] PROCESS_HOST_CHECK_RESULT;6479-keks;1;multiple foo 2
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254383] PROCESS_HOST_CHECK_RESULT;6479-keks;1;multiple foo 2
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254379] PROCESS_HOST_CHECK_RESULT;6479-keks;1;multiple foo 2
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254381] PROCESS_HOST_CHECK_RESULT;6479-keks;1;multiple foo 2
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254379] PROCESS_HOST_CHECK_RESULT;6479-keks;1;multiple foo 2
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254379] PROCESS_HOST_CHECK_RESULT;6479-keks;1;multiple foo 2
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254381] PROCESS_HOST_CHECK_RESULT;6479-keks;1;multiple foo 2
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254379] PROCESS_HOST_CHECK_RESULT;6479-keks;1;multiple foo 2
[2014-08-05 17:59:44 +0200] information/ExternalCommandListener: Executing external command: [1407254381] PROCESS_HOST_CHECK_RESULT;6479-keks;1;multiple foo 2
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] notice/ExternalCommandProcessor: Processing passive check result for host '6479-keks'
[2014-08-05 17:59:44 +0200] notice/Checkable: State Change: Checkable 6479-keks soft state change from UP to DOWN detected.

@icinga-migration
Copy link
Author

Updated by Anonymous on 2014-08-05 16:05:04 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 963125f.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-08-14 12:56:42 +00:00

  • Relates set to 6916

@icinga-migration icinga-migration added bug Something isn't working libicinga labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.0.2 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant