move some arrays to constants

icewind1991 · May 24, 2018 · 0d31da4 · 0d31da4
1 parent 4a5699f
commit 0d31da4
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 16 deletions.
diff --git a/src/Wrapped/Parser.php b/src/Wrapped/Parser.php
@@ -45,6 +45,15 @@ class Parser {
 		ErrorCodes::InvalidParameter  => InvalidParameterException::class
 	];
 
+	const MODE_STRINGS = [
+		'R' => FileInfo::MODE_READONLY,
+		'H' => FileInfo::MODE_HIDDEN,
+		'S' => FileInfo::MODE_SYSTEM,
+		'D' => FileInfo::MODE_DIRECTORY,
+		'A' => FileInfo::MODE_ARCHIVE,
+		'N' => FileInfo::MODE_NORMAL
+	];
+
 	/**
 	 * @param TimeZoneProvider $timeZoneProvider
 	 */
@@ -109,15 +118,7 @@ public function checkConnectionError($line) {
 
 	public function parseMode($mode) {
 		$result = 0;
-		$modeStrings = array(
-			'R' => FileInfo::MODE_READONLY,
-			'H' => FileInfo::MODE_HIDDEN,
-			'S' => FileInfo::MODE_SYSTEM,
-			'D' => FileInfo::MODE_DIRECTORY,
-			'A' => FileInfo::MODE_ARCHIVE,
-			'N' => FileInfo::MODE_NORMAL
-		);
-		foreach ($modeStrings as $char => $val) {
+		foreach (self::MODE_STRINGS as $char => $val) {
 			if (strpos($mode, $char) !== false) {
 				$result |= $val;
 			}

diff --git a/src/Wrapped/Share.php b/src/Wrapped/Share.php
@@ -45,6 +45,13 @@ class Share extends AbstractShare {
 	 */
 	private $system;
 
+	const MODE_MAP = [
+		FileInfo::MODE_READONLY => 'r',
+		FileInfo::MODE_HIDDEN   => 'h',
+		FileInfo::MODE_ARCHIVE  => 'a',
+		FileInfo::MODE_SYSTEM   => 's'
+	];
+
 	/**
 	 * @param IServer $server
 	 * @param string $name
@@ -327,13 +334,7 @@ public function write($target) {
 	 */
 	public function setMode($path, $mode) {
 		$modeString = '';
-		$modeMap = array(
-			FileInfo::MODE_READONLY => 'r',
-			FileInfo::MODE_HIDDEN   => 'h',
-			FileInfo::MODE_ARCHIVE  => 'a',
-			FileInfo::MODE_SYSTEM   => 's'
-		);
-		foreach ($modeMap as $modeByte => $string) {
+		foreach (self::MODE_MAP as $modeByte => $string) {
 			if ($mode & $modeByte) {
 				$modeString .= $string;
 			}