Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add page size checks for sync/async request mode #243

Open
JessicaS11 opened this issue Nov 9, 2021 · 2 comments
Open

add page size checks for sync/async request mode #243

JessicaS11 opened this issue Nov 9, 2021 · 2 comments
Labels
good first issue Good for newcomers IS2HW_2022 Potential project contributions for the 2022 ICESat-2 hackweek participants

Comments

@JessicaS11
Copy link
Member

There's still a reference to using a smaller page size in examples/examples/ICESat-2_DAAC_DataAccess_Example.ipynb because it refers to synchronous requests. Note that this notebook indicates that synchronous requests are done by default, but I think this must be outdated. It looks like the request mode is async by default (https://github.com/icesat2py/icepyx/blob/development/icepyx/core/APIformatting.py#L446).

Given that the page size limit is only 100 when the request mode is synchronous, maybe we need another check somewhere that decreases the page size when a user overrides that default and uses synchronous mode?

Originally posted by @trey-stafford in #239 (comment)

@JessicaS11
Copy link
Member Author

but I think this must be outdated

Or is an uncaught typo... I don't think sync was ever the default! Thanks for catching this.

@JessicaS11
Copy link
Member Author

maybe we need another check somewhere that decreases the page size when a user overrides that default and uses synchronous mode?

Based on #87, this may also need to mandate that page_num is provided if sync request mode is used.

@JessicaS11 JessicaS11 added good first issue Good for newcomers IS2HW_2022 Potential project contributions for the 2022 ICESat-2 hackweek participants labels Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers IS2HW_2022 Potential project contributions for the 2022 ICESat-2 hackweek participants
Projects
None yet
Development

No branches or pull requests

1 participant