From 62c950bc261a065f911ba0b86c37601084c21bdf Mon Sep 17 00:00:00 2001 From: littledan Date: Thu, 7 Jul 2016 13:07:21 -0700 Subject: [PATCH] Reland of [esnext] ship --harmony-object-values-entries (patchset #1 id:1 of https://codereview.chromium.org/2129533004/ ) Reason for revert: Performance stayed the same after the revert; relanding. Original issue's description: > Revert of [esnext] ship --harmony-object-values-entries (patchset #1 id:1 of https://codereview.chromium.org/2116053003/ ) > > Reason for revert: > Revert to see if it addresses the performance regression observed in chromium:625956 in automated graphs > > Original issue's description: > > [esnext] ship --harmony-object-values-entries > > > > BUG=v8:4663 > > R=littledan@chromium.org, adamk@chromium.org > > > > Committed: https://crrev.com/ab529234853a1768642f8f6c907aaaa5ea8b19bf > > Cr-Commit-Position: refs/heads/master@{#37485} > > TBR=adamk@chromium.org,caitpotter88@gmail.com > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=v8:4663 > > Committed: https://crrev.com/1177750a98faaa11e92ece13b70115bf704baf3b > Cr-Commit-Position: refs/heads/master@{#37566} TBR=adamk@chromium.org,caitpotter88@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4663 Review-Url: https://codereview.chromium.org/2127253002 Cr-Commit-Position: refs/heads/master@{#37596} --- src/flag-definitions.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/flag-definitions.h b/src/flag-definitions.h index 693f2c2dbb34..2eebc0de810d 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -216,7 +216,6 @@ DEFINE_IMPLICATION(es_staging, move_object_start) #define HARMONY_STAGED_BASE(V) \ V(harmony_regexp_lookbehind, "harmony regexp lookbehind") \ V(harmony_tailcalls, "harmony tail calls") \ - V(harmony_object_values_entries, "harmony Object.values / Object.entries") \ V(harmony_object_own_property_descriptors, \ "harmony Object.getOwnPropertyDescriptors()") \ V(harmony_async_await, "harmony async-await") \ @@ -231,10 +230,11 @@ DEFINE_IMPLICATION(es_staging, move_object_start) #endif // Features that are shipping (turned on by default, but internal flag remains). -#define HARMONY_SHIPPING(V) \ - V(harmony_restrictive_declarations, \ - "harmony limitations on sloppy mode function declarations") \ - V(harmony_exponentiation_operator, "harmony exponentiation operator `**`") +#define HARMONY_SHIPPING(V) \ + V(harmony_restrictive_declarations, \ + "harmony limitations on sloppy mode function declarations") \ + V(harmony_exponentiation_operator, "harmony exponentiation operator `**`") \ + V(harmony_object_values_entries, "harmony Object.values / Object.entries") // Once a shipping feature has proved stable in the wild, it will be dropped // from HARMONY_SHIPPING, all occurrences of the FLAG_ variable are removed,