Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Impala operation registry to base_sql backend #2463

Closed
datapythonista opened this issue Oct 12, 2020 · 3 comments
Closed

Move Impala operation registry to base_sql backend #2463

datapythonista opened this issue Oct 12, 2020 · 3 comments
Assignees
Labels
backends Issues related to all backends impala The Apache Impala backend onboarding Issues that can be addressed by someone less familiar with ibis refactor Issues or PRs related to refactoring the codebase

Comments

@datapythonista
Copy link
Contributor

datapythonista commented Oct 12, 2020

For historical reasons, some code shared among backends live in the Impala backend. An important part of the shared code has been moved to a new base_sql backend in #2449.

What is pending to move in a similar way is the operation registry (and its dependencies). Each backend has a registry of the operations it defines. And many backends are using the impala one to then overwrite what it's different.

What we should do is to move the common operations to base_sql. The registry dictionary, and also the functions that define the operations such as unary, reduce... which need to get the heading underscore removed, since they'll become public.. And leave in Impala the operations that are specific to Impala (using the moved registry as a base, as the other backends are doing).

@datapythonista datapythonista added refactor Issues or PRs related to refactoring the codebase impala The Apache Impala backend onboarding Issues that can be addressed by someone less familiar with ibis backends Issues related to all backends labels Oct 12, 2020
@matthewmturner
Copy link
Contributor

/take

@matthewmturner
Copy link
Contributor

this can be closed. sry i didnt link to my PR.

@datapythonista
Copy link
Contributor Author

Closed via #2469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backends Issues related to all backends impala The Apache Impala backend onboarding Issues that can be addressed by someone less familiar with ibis refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

No branches or pull requests

2 participants