Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of uninitialised value in libbacktrace/pecoff.c #3

Closed
ranma42 opened this issue Feb 22, 2017 · 1 comment
Closed

Use of uninitialised value in libbacktrace/pecoff.c #3

ranma42 opened this issue Feb 22, 2017 · 1 comment

Comments

@ranma42
Copy link

ranma42 commented Feb 22, 2017

In coff_add(), str_size is declared as a size_t, but if there is a symbol table, only 4 bytes of it are initialised:

memcpy (&str_size, syms_view.data + syms_size, 4);

str_size should probably be declared as a uint32_t.

The bug at rust-lang/rust#28447 was caused by this.
It was fixed in the Rust local copy of libbacktrace: rust-lang/rust@55e2b7e

This was reported at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69314

@dscho
Copy link

dscho commented Nov 18, 2017

Is this not addressed by #6? That Pull Request sits unanswered for months already, and it looks pretty good from my side, so I have no idea why you don't just click "Merge" @ianlancetaylor...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants