From 65c4008874d989398c319e7b87ee32490e31ce4e Mon Sep 17 00:00:00 2001 From: Anthony GULLIENT Date: Wed, 3 Apr 2024 15:26:40 +0200 Subject: [PATCH] fix(PointCloud): correct some issues after refacto --- examples/3dtiles_pointcloud.html | 4 +--- src/Parser/PntsParser.js | 2 +- src/Renderer/PointsMaterial.js | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/examples/3dtiles_pointcloud.html b/examples/3dtiles_pointcloud.html index 1d07c34bab..2441b08ad9 100644 --- a/examples/3dtiles_pointcloud.html +++ b/examples/3dtiles_pointcloud.html @@ -76,10 +76,8 @@ itowns.View.prototype.addLayer.call(view, $3dTilesLayerSetePC); function switchMode(){ let pntsLayer = view.getLayerById("3d-tiles-sete"); - if(pntsLayer){ - pntsLayer = pntsLayer; - pntsLayer.pntsMode = pntsLayer.pntsMode == itowns.PNTS_MODE.COLOR ? itowns.PNTS_MODE.CLASSIFICATION : itowns.PNTS_MODE.COLOR; + pntsLayer.pntsMode = pntsLayer.pntsMode === itowns.PNTS_MODE.COLOR ? itowns.PNTS_MODE.CLASSIFICATION : itowns.PNTS_MODE.COLOR; view.notifyChange(view.camera3D); } } diff --git a/src/Parser/PntsParser.js b/src/Parser/PntsParser.js index 31a6077b71..d0e982a514 100644 --- a/src/Parser/PntsParser.js +++ b/src/Parser/PntsParser.js @@ -135,6 +135,6 @@ function parseFeatureBinary(array, byteOffset, FTJSONLength) { function setClassification(point, batchTable) { if (!point.geometry) { return; } - if (batchTable.content && batchTable.content.Classification) { point.geometry.setAttribute('classification', new THREE.BufferAttribute(new Uint8Array(batchTable.content.Classification), 1, true)); } + if (batchTable.content && batchTable.content.Classification) { point.geometry.setAttribute('classification', new THREE.BufferAttribute(new Uint8Array(batchTable.content.Classification), 1)); } return point; } diff --git a/src/Renderer/PointsMaterial.js b/src/Renderer/PointsMaterial.js index fb587d2334..a365930d58 100644 --- a/src/Renderer/PointsMaterial.js +++ b/src/Renderer/PointsMaterial.js @@ -210,7 +210,7 @@ class PointsMaterial extends THREE.ShaderMaterial { delete options.elevationRange; delete options.angleRange; delete options.orientedImageMaterial; - delete options.classificationScheme; + delete options.classification; delete options.discreteScheme; delete options.applyOpacityClassication; delete options.size;