Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils.url_fix breaks url #41

Closed
sleighsoft opened this issue Dec 11, 2019 · 1 comment · Fixed by #42
Closed

utils.url_fix breaks url #41

sleighsoft opened this issue Dec 11, 2019 · 1 comment · Fixed by #42

Comments

@sleighsoft
Copy link

sleighsoft commented Dec 11, 2019 •
edited
Loading

When using url_fix it corrupts a valid url:

self.mirrors[0]
'<url_removed>'

utils.url_fix(self.mirrors[0])
'<url_removed>'

Given that True is the default it took me a long time to figure this out...
@iTaybb iTaybb mentioned this issue Dec 13, 2019
Merged
@iTaybb
Copy link
Owner

iTaybb commented Dec 13, 2019 •
edited
Loading

A fix will be pushed to master soon. I'll put it in the next release. Until then, you can set fix_urls=False at the SmartDL constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix_url: better escaping for urls iTaybb/pySmartDL
2 participants
@iTaybb @sleighsoft