Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nip17 DMs #237

Open
Giszmo opened this issue Sep 21, 2024 · 7 comments · May be fixed by #244
Open

Enable nip17 DMs #237

Giszmo opened this issue Sep 21, 2024 · 7 comments · May be fixed by #244
Labels
help wanted Extra attention is needed wontfix This will not be worked on

Comments

@Giszmo
Copy link

Giszmo commented Sep 21, 2024

nip17 is getting more and more adoption and people chat me and then wonder why I never reply :(

Apparently "people" is only one so far but still, it's an important privacy improvement.

I offer a $200 bounty for this.

@aybanda
Copy link

aybanda commented Sep 21, 2024

working on this @Giszmo
will try deliver this very soon

@hzrd149 hzrd149 added help wanted Extra attention is needed wontfix This will not be worked on labels Sep 28, 2024
@hzrd149
Copy link
Owner

hzrd149 commented Sep 28, 2024

I would like to add this to noStrudel. however its not on my priority list at all and IMO other DM focused apps can handle this better

@Giszmo
Copy link
Author

Giszmo commented Sep 30, 2024

@hzrd149 are you saying that you would merge what @aybanda is working on if it looked good? Apparently he's doing the heavy lifting of an initial implementation already.

@hzrd149
Copy link
Owner

hzrd149 commented Sep 30, 2024

yes, with a few conditions.

The code would have to be reasonably organized and modular (should work independently without relying on other parts of the app loading first etc...)

Does not prompt the user to decrypt events as soon as the apps loads. In other words it should work with the user manually approving every decryption request and shouldn't be "too" annoying

I realize I haven't really helped at all here since I don't have contributing guidelines written up or any docs 😞

@aybanda
Copy link

aybanda commented Sep 30, 2024

Hey @Giszmo @hzrd149
check this out #243

@Giszmo
Copy link
Author

Giszmo commented Sep 30, 2024

@aybanda I left a comment on your PR and saw other issues but I'm not fully familiar with how nostrudel or nip17 work so I'll leave it to you to fix this and will test again when you think it should work.

In summary, I'm pretty sure I got asked to decrypt more messages than I had received nip17 events while I did not get to see any nip17 messages in the end.

@jackedproxy
Copy link

Very much looking forward to this, and I know a few others who are too.
Other than Coracle, I'm not aware of another client that implements Nip17 at this point (and I'm also having issues with that one).
I use noStrudel all day every day at this point when at a desktop, but not being able to receive encrypted messages from my partner and friends who use app like 0xchat and Amethyst (nip17 ones) is becoming a problem.

I realize I have no rep here, but I'd really like to somehow add an extra $100 to the bounty on top of @Giszmo .

@aliraza556 aliraza556 linked a pull request Oct 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants