Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When selecting text, adder sometimes fails to show up #501

Closed
csillag opened this issue Jul 11, 2013 · 4 comments
Closed

When selecting text, adder sometimes fails to show up #501

csillag opened this issue Jul 11, 2013 · 4 comments
Assignees
@csillag
Milestone
h v0.1

Comments

@csillag
Copy link
Contributor

csillag commented Jul 11, 2013

I have seen this with both Chrome and FF.

If I select a longer piece of text (more than 4 or 5 paragraphs), sometimes the adder icon is not shown at all.

Somehow, it looks like the probability of this happening is lower if I do a upward-dragging selection than with the normal (downward-dragging) selection, but that might be an illusion.

Does not seem to be happening with shorter pieces of text.
@csillag
Copy link
Contributor Author

csillag commented Jul 11, 2013

This is present in upstream Annotator, too. I have just filed openannotation/annotator#235

@ghost ghost assigned csillag Jul 12, 2013
@csillag
Copy link
Contributor Author

csillag commented Jul 12, 2013

Actually, the text does not have to be that long; it's more about the empty space between the paragraphs...

@csillag
Copy link
Contributor Author

csillag commented Jul 13, 2013

I have fixed this in upstream annotator. (PR: openannotation/annotator#238 )
Now I need to (manually) merge the fix into our fork.

@csillag csillag mentioned this issue Jul 17, 2013
Closed
@csillag
Copy link
Contributor Author

csillag commented Oct 23, 2013

I think I have fixed this on the PDF branch. Maybe I will migrate the fix to the dev branch, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csillag csillag

Labels
None yet
Projects
None yet
Milestone
h v0.1
Development

No branches or pull requests
1 participant
@csillag