Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelled annotations reappear when moving between groups #3561

Closed
seanh opened this issue Jun 29, 2016 · 0 comments · Fixed by hypothesis/client#8
Closed

Cancelled annotations reappear when moving between groups #3561

seanh opened this issue Jun 29, 2016 · 0 comments · Fixed by hypothesis/client#8

Comments

@seanh
Copy link
Contributor

seanh commented Jun 29, 2016

  1. Create a new annotation but hit Cancel instead of Post
  2. Move to another group

Result: the cancelled annotation reappears in the new group.

Keep cancelling it, every time you switch groups all cancelled annotations will come back.

Expected: once I hit Cancel on a new annotation that I never saved to the server it's gone, does not reappear ever. I can't remember whether we used to have an "Are you sure?" confirmation dialog for this cancel (given that you'll permanently lose anything you entered into the card).

untitled screencast - edited 22

The Post button on the reappearing cancelled annotation is confused about what group it's in, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant