Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out what's going on with focus and button styling #126

Closed
lyzadanger opened this issue Jun 28, 2021 · 0 comments · Fixed by #145
Closed

Figure out what's going on with focus and button styling #126

lyzadanger opened this issue Jun 28, 2021 · 0 comments · Fixed by #145
Assignees
@lyzadanger
Labels
pattern library concerning the build, structure, styling or components for the pattern library

Comments

@lyzadanger
Copy link
Contributor

Although the button patterns and components use the outline-on-keyboard-focus focus mixin, they don't appear to have any focus rings at all in the pattern library. However, these same buttons do have keyboard-focus outlines when used in the client:

image

A little bit of sleuthing is needed here: why are these getting outlines when used in the client but not in the pattern-library pages?
@lyzadanger lyzadanger added the pattern library concerning the build, structure, styling or components for the pattern library label Jun 28, 2021
@lyzadanger lyzadanger self-assigned this Jul 14, 2021
@lyzadanger lyzadanger mentioned this issue Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lyzadanger lyzadanger

Labels
pattern library concerning the build, structure, styling or components for the pattern library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make :focus-visible rules work when polyfill not present hypothesis/frontend-shared
1 participant
@lyzadanger