From ec72ad31a263f93818747c48ee5aab605625ec19 Mon Sep 17 00:00:00 2001 From: Sean Hammond Date: Wed, 19 Apr 2017 14:36:33 +0100 Subject: [PATCH] Remove a broken unit test As noted in this comment: https://github.com/hypothesis/client/pull/356#discussion_r111998459 this test doesn't actually test what it says it does, and fixing the test would require some refactoring of the code under test. For now, just delete the test. --- src/sidebar/test/service-url-test.js | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/sidebar/test/service-url-test.js b/src/sidebar/test/service-url-test.js index 16dccbeecaa..6de8c83a8e4 100644 --- a/src/sidebar/test/service-url-test.js +++ b/src/sidebar/test/service-url-test.js @@ -75,16 +75,6 @@ describe('links', function () { }); }); - context('if the API request fails', function() { - it('just keeps returning empty strings for URLs', function() { - var linksPromise = Promise.reject(new Error('Oops')); - - var serviceUrl = createServiceUrl(linksPromise).serviceUrl; - - assert.equal(serviceUrl('second_link'), ''); - }); - }); - context('after the API response has been received', function() { var annotationUI; var linksPromise;