Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure get_creator implementation #357

Open
g2flyer opened this issue May 14, 2020 · 2 comments
Open

Secure get_creator implementation #357

g2flyer opened this issue May 14, 2020 · 2 comments

Comments

@g2flyer
Copy link
Contributor

g2flyer commented May 14, 2020

Description
Currently we just get the creator-name as-is from the untrusted part. To make it secure, we will have to pass the signed-proproposal to ecc which then will have to verify it and extract the creator info. As this also involves MSP validation and alike which tlcc has to do (see e.g., issue #125), this is probably best done via a RPC to TLCC.

@g2flyer g2flyer added this to the MVP milestone May 14, 2020
@g2flyer g2flyer removed this from the MVP FPC 1.0 (aka FPC Lite) milestone Dec 8, 2020
@g2flyer
Copy link
Contributor Author

g2flyer commented Dec 8, 2020

tabled until we have trusted ledger ...

@g2flyer g2flyer added this to the Rollback protection extension milestone Dec 8, 2020
@mbrandenburger
Copy link
Contributor

This is partially addressed with #637. We ensure that the creator identity returned by the function is indeed backed with the data from the signed transaction proposal. However, still, without the trusted ledger we cannot check the returned identity with the MSP of the channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants