Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privacy ATs failing because tx pool not enabled during sync #6402

Closed
macfarla opened this issue Jan 15, 2024 · 3 comments · Fixed by #6479
Closed

privacy ATs failing because tx pool not enabled during sync #6402

macfarla opened this issue Jan 15, 2024 · 3 comments · Fixed by #6479
Assignees
Labels
dev experience The build system, things that enable easier development etc. help wanted Extra attention is needed non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT snack Smaller coding task - less than a day for an experienced dev TeamRevenant GH issues worked on by Revenant Team testing

Comments

@macfarla
Copy link
Contributor

think we need a similar fix as was done here for permissioning ATs #6384

Note privacy ATs currently running on nightly CI only (not on PRs)

example failure here https://app.circleci.com/pipelines/github/hyperledger/besu/26334/workflows/9ca2d46b-92df-4646-9e7d-fe9153826766/jobs/173226 with error "Transaction pool not enabled"

@macfarla macfarla added dev experience The build system, things that enable easier development etc. non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT TeamRevenant GH issues worked on by Revenant Team testing labels Jan 15, 2024
@macfarla
Copy link
Contributor Author

macfarla commented Jan 15, 2024

cc @gtebrean this flakiness may impact you on #5968 - do you want to have a go at fixing this one?

@macfarla macfarla added help wanted Extra attention is needed snack Smaller coding task - less than a day for an experienced dev labels Jan 15, 2024
@gtebrean gtebrean self-assigned this Jan 15, 2024
@macfarla macfarla reopened this Feb 13, 2024
@macfarla
Copy link
Contributor Author

reopening this since we're still seeing occasional failures - flakiness with "Invalid params" or sometimes "tx pool not enabled" - so we think something is missing with the sync checks, getting receipts, web3j and the transaction pool

@macfarla
Copy link
Contributor Author

example failure

PrivacyClusterAcceptanceTest > [TESSERA enclave type with EC encryptor] > org.hyperledger.besu.tests.acceptance.privacy.PrivacyClusterAcceptanceTest.canInteractWithMultiplePrivacyGroups[TESSERA enclave type with EC encryptor] FAILED
    java.lang.RuntimeException: org.web3j.protocol.exceptions.TransactionException: Error processing request: Invalid params
        at org.hyperledger.besu.tests.acceptance.dsl.privacy.condition.PrivGetTransactionReceiptTransaction.execute(PrivGetTransactionReceiptTransaction.java:49)
        at org.hyperledger.besu.tests.acceptance.dsl.privacy.condition.PrivGetTransactionReceiptTransaction.execute(PrivGetTransactionReceiptTransaction.java:29)
        at org.hyperledger.besu.tests.acceptance.dsl.node.BesuNode.execute(BesuNode.java:810)
        at org.hyperledger.besu.tests.acceptance.dsl.privacy.PrivacyNode.execute(PrivacyNode.java:247)
        at org.hyperledger.besu.tests.acceptance.privacy.PrivacyClusterAcceptanceTest.canInteractWithMultiplePrivacyGroups(PrivacyClusterAcceptanceTest.java:350)

        Caused by:
        org.web3j.protocol.exceptions.TransactionException: Error processing request: Invalid params
            at app//org.web3j.tx.response.PrivateTransactionReceiptProcessor.sendTransactionReceiptRequest(PrivateTransactionReceiptProcessor.java:38)
            at app//org.web3j.tx.response.PollingPrivateTransactionReceiptProcessor.getTransactionReceipt(PollingPrivateTransactionReceiptProcessor.java:45)
            at app//org.web3j.tx.response.PollingPrivateTransactionReceiptProcessor.waitForTransactionReceipt(PollingPrivateTransactionReceiptProcessor.java:36)
            at app//org.hyperledger.besu.tests.acceptance.dsl.privacy.condition.PrivGetTransactionReceiptTransaction.execute(PrivGetTransactionReceiptTransaction.java:45)
            ... 4 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev experience The build system, things that enable easier development etc. help wanted Extra attention is needed non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT snack Smaller coding task - less than a day for an experienced dev TeamRevenant GH issues worked on by Revenant Team testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants